Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial fee breakdown public UI #4006

Merged
merged 10 commits into from
Nov 27, 2024
Merged

feat: Initial fee breakdown public UI #4006

merged 10 commits into from
Nov 27, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 25, 2024 •
edited
Loading

What does this PR do?

  • Adds a FEE_BREAKDOWN feature flag
  • Allows fee breakdown to be toggled in the Editor
  • Displays a very basic fee breakdown table in the Public "Pay" component
    • This is just UI initially - there's no data here at all, these are just dummy values and not read from the passport
    • I've got a few ideas of how this could work, but having a UI first will help hang a few discussions around this - planning to have some ideas to talk through and maybe demo at dev calls this week
  • Storybook link here - https://storybook.4006.planx.pizza/?path=/story/planx-components-pay--with-fee-breakdown
image

@DafyddLlyr
Copy link
Contributor Author

Show a breakdown of planning fee + service charge to users

@DafyddLlyr DafyddLlyr requested a review from a team November 25, 2024 20:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

jamdelion
jamdelion reviewed Nov 26, 2024
View reviewed changes
editor.planx.uk/src/@planx/components/Pay/Public/Pay.stories.tsx
Comment on lines +20 to +22
loaders: [
() => window.localStorage.setItem("FEATURE_FLAGS", '["FEE_BREAKDOWN"]'),
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh didn't know you could do this! 💡

jamdelion
jamdelion approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jamdelion jamdelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to read and looks like a solid start ⭐ Great to see test intentions laid out up front too

@DafyddLlyr DafyddLlyr merged commit 3a52971 into main Nov 27, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/fee-breakdown-ui branch November 27, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamdelion jamdelion jamdelion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jamdelion