Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add feedback component into e2e flow #4008

Merged
merged 4 commits into from
Nov 27, 2024
Merged

test: add feedback component into e2e flow #4008

merged 4 commits into from
Nov 27, 2024

Conversation

jamdelion
Copy link
Contributor

@jamdelion jamdelion commented Nov 26, 2024 •
edited
Loading

In this PR:

  • Add the new feedback component to the create-flow test, testing both the editor ("can I insert this component in a flow?") and user side ("can I interact with this component in a flow?").
  • Includes a couple of changes from Rory's upcoming PR to fix pre-existing bugs in the tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jamdelion jamdelion changed the title jh/e2e feedback component test: add feedback component into e2e flow Nov 26, 2024
@jamdelion jamdelion mentioned this pull request Nov 26, 2024
Closed
@jamdelion jamdelion marked this pull request as ready for review November 26, 2024 15:02
@jamdelion jamdelion requested a review from a team November 26, 2024 15:02
@jamdelion jamdelion merged commit 618f37d into main Nov 27, 2024
12 checks passed
@jamdelion jamdelion deleted the jh/e2e-feedback-component branch November 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamdelion @DafyddLlyr