-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: How to add fields to search #4016
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
# How to add fields to the Editor search index | ||
|
||
## Overview | ||
|
||
This guide outlines the process of adding new searchable fields to the PlanX Editors' frontend search functionality, which uses Fuse.js for indexing and searching. This is a required step with adding a new component to PlanX, or adding new fields to an existing component. | ||
|
||
## Background | ||
|
||
- Search is currently implemented in the frontend using Fuse.js | ||
- Only certain fields are searchable: | ||
- Text fields (simple text) | ||
- Rich text fields (HTML) | ||
- Data values (e.g. `data.fn`) | ||
|
||
## Process | ||
|
||
### 1. Update facets configuration | ||
|
||
Location: `src/pages/FlowEditor/components/Sidebar/Search/facets.ts` | ||
|
||
#### Guidelines: | ||
- Use key paths to the new fields (e.g. `data.myNewField`) | ||
- Wrap rich text fields with `richTextField()` helper - this strips HTML tags | ||
- Add data fields to `DATA_FACETS` | ||
- Add text fields to `ALL_FACETS` | ||
- Avoid adding duplicate values already held in `ALL_FACETS` (e.g., `data.title`, `data.description`) | ||
|
||
#### Example: | ||
|
||
```ts | ||
// facets.ts | ||
|
||
const myNewComponent: SearchFacets = [ | ||
richTextField("data.myRichTextField"), | ||
"data.myPlainTextField" | ||
]; | ||
|
||
export const ALL_FACETS: SearchFacets = [ | ||
...otherComponents, | ||
...myNewComponent, | ||
...DATA_FACETS, | ||
]; | ||
``` | ||
|
||
### 2. Assign display values | ||
|
||
Location: `src/pages/FlowEditor/components/Sidebar/Search/SearchResultCard/getDisplayDetailsForResult.tsx` | ||
|
||
#### Add key formatters: | ||
|
||
```ts | ||
// getDisplayDetailsForResult.tsx | ||
|
||
const keyFormatters: KeyMap = { | ||
...existingFormatters, | ||
"data.myNewField": { | ||
getDisplayKey: () => "My New Field", | ||
}, | ||
}; | ||
``` | ||
|
||
### 3. Update tests | ||
|
||
Locations: | ||
- `src/pages/FlowEditor/components/Sidebar/Search/SearchResultCard/allFacets.test.ts` | ||
- `src/pages/FlowEditor/components/Sidebar/Search/SearchResultCard/dataFacets.test.ts` | ||
|
||
#### Test steps: | ||
1. Add new component to `mockFlow` | ||
2. Create mock search result | ||
- Example: `mockMyComponentResult: SearchResult<IndexedNode>` | ||
|
||
### Debugging tip | ||
|
||
A search result can be easily logged to the console from `SearchResultCard`. Simply search for one of your new fields, and click on the card. | ||
|
||
```ts | ||
// SearchResultCard/index.tsx | ||
|
||
const handleClick = () => { | ||
const url = getURLForNode(result.item.id); | ||
// Temporarily disable navigation | ||
// navigate(url); | ||
|
||
// Log the full search result to console | ||
console.log({ result }); | ||
}; | ||
``` | ||
|
||
For reference, [please see this PR](https://github.com/theopensystemslab/planx-new/pull/4015) which added the text fields for the `Feedback` component to the search index. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍