Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clone styling for Questions with data variables or tags #4017

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 28, 2024

What does this PR do?

Updates structure of graph nodes so that is the isClone class always targets all children within a single div element.

Before After
image image
Border not applied to sibling data tag, 3px gap Border applied to single parent div, 3px gap is correctly offsetting hanger above

Copy link

github-actions bot commented Nov 28, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team November 28, 2024 14:58
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 28, 2024 14:58
imageSource={props.data?.img}
imageAltText={props.data?.text}
/>
<Box>
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping this in the box ensures that the &.isClone > div selector is now properly targeted, matching how checkboxes are already set up.

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and tested well on the pizza following the messages on the Slack thread

@DafyddLlyr DafyddLlyr merged commit bcf0e47 into main Nov 28, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/clone-styling-fix branch November 28, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants