feat(fee-breakdown): Initial Editor UI #4030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Dec 3, 2024
| <TableCell>Reduction</TableCell> | ||
| <TableCell align="right" sx={{ display: "flex", alignItems: "center" }}> | ||
| <HelpTooltip text="This is the sum of all reductions applied to the application fee. The list of reductions will be listed below" /> | ||
| <DataField>- £ (calculated - payable)</DataField> |
There was a problem hiding this comment.
I'm not sure if this shorthand for application.fee.calculated - application.fee.payable is that clear?
The "full" version pretty much always overflows and feels less clear even though the above is not technically correct.
|
Closing in favour of a list based approach and not a illustrative table / fee breakdown. Will reference this PR as prior art! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Questions
I've hardcoded
application.feeas a prefix here, but this is a dynamic key.In reality we know that all active services (apart from one) currently pass through the osl/fee-calculator flow which rely on this variable.
Here's the question - should we keep this dynamic, or make the field disabled in the Pay component and always set to
application.fee(after double checking services)? I think making it static leans more towards the "SetFee" component approach we discussed, but isn't without downsides. Maybe one for the dev call!