fix: when next step is deleted, props.value doesn't update #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Thanks for picking this one up! Pizza working as expected for me, would be good to get this one merged & live to un-block content team if you and August are also happy with it 👍
In future, this bug/expected behavior also feels like a good candidate to write a unit test for (eg NextSteps/Editor.test.ts → it("preserves existing steps values when one is deleted"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that when you deleted a step from the NextSteps component, it wouldn't set
descriptionorurlto "", but not set it at all. This meant previous values with the same index would persist until it is submitted then when it is reloaded, data would return to the formik saved values.Looked into trying to alter the data model, but got a bit caught up in the components and functions with the way they are passed down and back up. Open to suggestions on a more robust change, but this seemed to work.