feat: E2E coverage for Draw Boundary #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RODO94
force-pushed
the
rory/e2e-draw-boundary
branch
from
6251e38 to
dc9caa0
Compare
|
Removed vultr server and associated DNS entries |
RODO94
force-pushed
the
rory/e2e-draw-boundary
branch
from
26d70e0 to
c5a5d7c
Compare
RODO94
commented
Dec 10, 2024
| @@ -37,3 +43,23 @@ export const mockMapGeoJson: Feature = { | |||
| "organisation-entity": "13", | |||
| }, | |||
| }; | |||
|
|
|||
| export const mockChangedMapGeoJson: GeoJsonChangeHandler = { | |||
There was a problem hiding this comment.
pulled this from the tests so I had a static mock to check against when running the tests
There was a problem hiding this comment.
This looks like a solid start! Some initial comments below and a larger one:
- I was expecting to find mocks for Ordnance Survey API calls as part of this work - when you load up the DrawBoundary here, is it making live calls to the OS Vector Tiles API ? Are OS mocks something you previously handled with FindProperty & PropertyInformation components before this ?
We definitely don't want our live OS APIs to be called repeated by E2E so let's catch up about this please to move this forward !
remove upload and label refs initial expects for area and uplaod file button
RODO94
force-pushed
the
rory/e2e-draw-boundary
branch
from
ea4c351 to
cd70fe5
Compare
address comments from review refine osMapsMocks rename OSMapMocks
RODO94
force-pushed
the
rory/e2e-draw-boundary
branch
from
d086f26 to
e2d2534
Compare
jessicamcinchak
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Test do?
For the Draw Boundary testing, I have focused only on:
I have left testing the file upload to the relevant unit tests or related testing elsewhere in the code base. I thought this was the easiest given we are yet to do the
FileUploadAndLabele2e tests. I can come back to add this in after that.Rather than add in comments, in some parts I have just added custom text to the
expect(). It made it easier for me to track when running the test and it was acting the same as the comments in the code.