Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove toggle for FeeBreakdown #4039

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Dec 4, 2024

Quick change following design call - this feature doesn't need to be toggleable. It's still behind a feature flag but once this is removed it will always be shown on the public facing Pay component.

@DafyddLlyr DafyddLlyr requested a review from a team December 4, 2024 15:19
Copy link

github-actions bot commented Dec 4, 2024

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification! Appreciate you taking in all our feedback at design call on this surprisingly complex one!

@DafyddLlyr DafyddLlyr merged commit ff0946d into main Dec 4, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/always-show-fee-breakdown branch December 4, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants