feat(fee-breakdown): Parse and display discrete list of reductions and exemptions #4040
Conversation
DafyddLlyr
changed the title
DafyddLlyr
force-pushed
the
dp/simple-fee-breakdown
branch
2 times, most recently
from
5569c90 to
bd6ad07
Compare
DafyddLlyr
force-pushed
the
dp/discrete-exemptions-reductions
branch
from
a6d46c3 to
4a34dfc
Compare
DafyddLlyr
force-pushed
the
dp/discrete-exemptions-reductions
branch
from
4a34dfc to
84338ad
Compare
|
Removed vultr server and associated DNS entries |
| <FeeBreakdownSection /> | ||
| <GovPayMetadataSection/> | ||
| <InviteToPaySection/> | ||
| <FeeBreakdownSection/> |
There was a problem hiding this comment.
nit: understand this is just a linting change here, but going forward I think we'll want to re-order the Pay modal to better match the info-heirarchy of the public display? Eg should GovPayMetdataSection be last because it's "internal"/on-submit only and FeeBreakdown be before InviteToPay because a) it'll always apply and b) it's visually higher on the page than the "Invite someone else to pay" button ?
There was a problem hiding this comment.
Great observation, will pick up this change when I come back to the styling of this component shortly 👍
| /** | ||
| * Convert a Passport value to an actual boolean | ||
| */ | ||
| const toBoolean = (val: ["true" | "false"]) => val[0] === "true"; |
There was a problem hiding this comment.
Let's make a proper lib of passport helpers in planx-core or similar one of these days 💫
What does this PR do?
@descriptionsfields)