-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create baseOptionsEditor and delete duplicates #4041
Conversation
6470404
to
93af5ce
Compare
Removed vultr server and associated DNS entries |
de56a8d
to
2aabdc6
Compare
Realising now that I'm deeper into the ticket that these should be more separated than I thought. There are still common elements that I will extract out to reduce duplication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this - only one small issue I've spotted.
editor.planx.uk/src/@planx/components/Checklist/Editor/OptionsEditor.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
More refactoring! I noticed we had two large subcomponents that looked very similar - the
OptionsEditor
for checklists and questions. I've changed this so that there is oneBaseOptionsEditor
component in the shared folder, that is used in both places with children to handle the differences between them. I think they work the same, but do shout if I've missed anything!