Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create baseOptionsEditor and delete duplicates #4041

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

jamdelion
Copy link
Contributor

@jamdelion jamdelion commented Dec 4, 2024

More refactoring! I noticed we had two large subcomponents that looked very similar - the OptionsEditor for checklists and questions. I've changed this so that there is one BaseOptionsEditor component in the shared folder, that is used in both places with children to handle the differences between them. I think they work the same, but do shout if I've missed anything!

@jamdelion jamdelion force-pushed the jh/checklist-with-or-after-refactor branch from 6470404 to 93af5ce Compare December 4, 2024 16:22
Copy link

github-actions bot commented Dec 4, 2024

Removed vultr server and associated DNS entries

@jamdelion jamdelion marked this pull request as ready for review December 4, 2024 17:14
@jamdelion jamdelion changed the base branch from jh/checkist-with-or to main December 4, 2024 17:14
@jamdelion jamdelion changed the base branch from main to jh/checkist-with-or December 4, 2024 17:15
@jamdelion jamdelion changed the base branch from jh/checkist-with-or to main December 4, 2024 17:39
@jamdelion jamdelion changed the base branch from main to jh/checkist-with-or December 4, 2024 17:40
@jamdelion jamdelion force-pushed the jh/checklist-with-or-after-refactor branch from de56a8d to 2aabdc6 Compare December 5, 2024 11:23
@jamdelion jamdelion changed the base branch from jh/checkist-with-or to main December 5, 2024 11:23
@jamdelion
Copy link
Contributor Author

Realising now that I'm deeper into the ticket that these should be more separated than I thought. There are still common elements that I will extract out to reduce duplication

@jamdelion jamdelion closed this Dec 5, 2024
@jamdelion jamdelion reopened this Dec 5, 2024
@jamdelion jamdelion marked this pull request as draft December 5, 2024 12:24
@jamdelion jamdelion changed the title refactor: remove duplicate optionsEditor and move into shared component refactor: create baseOptionsEditor and delete duplicates Dec 5, 2024
@jamdelion jamdelion marked this pull request as ready for review December 5, 2024 14:08
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this - only one small issue I've spotted.

@jamdelion jamdelion requested a review from DafyddLlyr December 11, 2024 11:29
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jamdelion jamdelion merged commit f446f0b into main Dec 12, 2024
12 checks passed
@jamdelion jamdelion deleted the jh/checklist-with-or-after-refactor branch December 12, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants