fix: account for expandable checklists in editor modal passport value validation #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
changed the title
jamdelion
approved these changes
Dec 5, 2024
DafyddLlyr
approved these changes
Dec 5, 2024
jessicamcinchak
deleted the
jess/expandable-option-data-val-validation-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagged here https://opensystemslab.slack.com/archives/C01E3AC0C03/p1733408598813289
We don't currently have an
Editor.test.tsxfile for Checklists but happy to revisit that as a follow-up PR so we don't miss this again ! Probably nice to merge now though to minimise rebases for Jo 🙂