Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exclusive 'Or' option in checklists #4056
feat: exclusive 'Or' option in checklists #4056
Changes from 23 commits
a70d00f
32689a2
bf201d3
2aabdc6
cc9fe24
db6fe7f
63eb8f2
dacbb0f
688bff6
0683fd5
2498c3c
155dd91
76fa41c
3491906
2bbf8ee
60f159d
f434f3f
9e582f3
6ccff9f
9ba4336
919b408
56e3e75
f892565
40e7427
1203531
4f27259
0b61774
687ad69
3d3c9c7
9585660
ef50330
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be quite nice to split some of these sections up into their components so that the structure if overall more discernable at a glance. Right now it's quite nested and complex to follow.
The catch here is that we need
formik
in all of them.We can certainly prop drill this along, or wrap the children in
FormikContext
and then access the values via theuseFormikContext()
hook. There's a good example of this in the invite to pay and GovPay metadata sections of the code base 👍This can for sure be another PR or a fix-forward issue and doesn't need to be directly addressed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's possibly a number of places where this could be reused -
This is needed because we're not using Formik to totally control the state of these checkboxes using the
Field
component so have to do it manually https://formik.org/docs/examples/checkboxesThis would be a nice follow up PR to try and address 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely agree, I will follow-up on this in the next PR, and also split up some of the component files a bit more.