feat: Display Pay component when fee is zero
#4067
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/display-zero-fees
branch
3 times, most recently
from
e9c66f3 to
d09dbc0
Compare
DafyddLlyr
force-pushed
the
dp/display-zero-fees
branch
from
d09dbc0 to
c5eaa0c
Compare
jessicamcinchak
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Overall all working as expected & now displaying when fee = 0 ✔️
Spent quite a bit of time on the pizza and a few minor nit pick comments that I don't believe are introduced here:
- Should we capitalize the first letter of the type of reduction or exemption for consistency? (in interim until fetching from schema
@description?) - I was surprised to get this breakdown (reductions "-129", exemptions "-0") with this passport - I would expect no line item for reductions, and "-129" for exemptions?
Was testing on this flow: https://4067.planx.pizza/barnet/pay-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Confirmcomponent to more explicitly handle various statesConfirmin instances where fee is £0There's still scope here for a content pass through which I'm going to address once this feature is technically complete (e.g. the title "pay for your application" is not very meaningful when we know the fee is £0.)