refactor: split Checklist into sub-components and hooks #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdelion
changed the title
jamdelion
force-pushed
the
jh/refactor-checklist-more
branch
from
628dc66 to
79b9f86
Compare
jamdelion
changed the title
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Dec 18, 2024
editor.planx.uk/src/@planx/components/Checklist/Public/components/ExclusiveChecklistItem.tsx
Outdated
Show resolved
Hide resolved
DafyddLlyr
approved these changes
Dec 18, 2024
editor.planx.uk/src/@planx/components/Checklist/Public/Public.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/Checklist/Public/components/ChecklistItems.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/Checklist/Public/components/ChecklistItems.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| export const useExclusiveOption = ( | ||
| exclusiveOptions: Option[], | ||
| formik: FormikProps<{ checked: Array<string> }> |
There was a problem hiding this comment.
nit: Seeing this prop many times in this PR points towards useFormikContext() being something worth considering. Not a blocker for sure.
|
A few nitpicks but no show stoppers - nice reorganisation, especially pulling logic out into clear and concise hooks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
GroupedChecklistOptions,ExclusiveChecklistOptionandChecklistItemsfrom thePublicchecklist component to make the file easier to read.useExclusiveOptionto move the complexity out of the single dense file.