Find suitable value for oneOf property in parameters. Fix #166

src/PSR7/Validators/SerializedParameter.php

@@ -11,10 +11,12 @@
 use League\OpenAPIValidation\Schema\Exception\InvalidSchema;
 use League\OpenAPIValidation\Schema\Exception\SchemaMismatch;
 use League\OpenAPIValidation\Schema\Exception\TypeMismatch;
+use League\OpenAPIValidation\Schema\SchemaValidator;
 use Respect\Validation\Exceptions\Exception;
 use Respect\Validation\Exceptions\ExceptionInterface;
 use Respect\Validation\Validator;
 
+use function count;
 use function explode;
 use function in_array;
 use function is_array;
@@ -181,6 +183,14 @@ protected function convertToSerializationStyle($value, ?CebeSchema $schema)
         if ($schema && $this->style === self::STYLE_DEEP_OBJECT) {
             foreach ($value as $key => &$val) {
                 $childSchema = $this->getChildSchema($schema, (string) $key);
+
+                if (isset($childSchema->oneOf)) {
+                    $suitableSchema = $this->findSuitableOneOf($childSchema, $val);
+                    if ($suitableSchema) {
+                        $childSchema = $suitableSchema;
+                    }
+                }
+
                 if (is_array($val)) {
                     $val = $this->convertToSerializationStyle($val, $childSchema);
                 } else {
@@ -217,4 +227,29 @@ protected function getChildSchema(CebeSchema $schema, string $key): ?CebeSchema
 
         return null;
     }
+
+    /**
+     * @param mixed $val
+     */
+    private function findSuitableOneOf(CebeSchema $schema, $val): ?CebeSchema
+    {
+        if (! count($schema->oneOf)) {
+            return null;
+        }
+
+        $schemaValidator = new SchemaValidator(SchemaValidator::VALIDATE_AS_REQUEST);
+        $validSchemas    = [];
+        foreach ($schema->oneOf as $schemaCandidate) {
+            try {
+                $valCandidate = $this->convertToSerializationStyle($val, $schemaCandidate);
+
+                $schemaValidator->validate($valCandidate, $schemaCandidate);
+                $validSchemas[] = $schemaCandidate;
+            } catch (SchemaMismatch $e) {
+                // nothing to do
+            }
+        }
+
+        return count($validSchemas) === 1 ? $validSchemas[0] : null;
+    }
 }

tests/FromCommunity/Issue166Test.php

@@ -0,0 +1,72 @@
+<?php
+
+declare(strict_types=1);
+
+namespace League\OpenAPIValidation\Tests\FromCommunity;
+
+use GuzzleHttp\Psr7\ServerRequest;
+use League\OpenAPIValidation\PSR7\Exception\Validation\InvalidQueryArgs;
+use League\OpenAPIValidation\PSR7\ValidatorBuilder;
+use League\OpenAPIValidation\Tests\PSR7\BaseValidatorTest;
+
+use function parse_str;
+
+/**
+ * @see https://github.com/thephpleague/openapi-psr7-validator/issues/166
+ */
+final class Issue166Test extends BaseValidatorTest
+{
+    public function testIssue166(): void
+    {
+        $yaml = /** @lang yaml */
+            <<<YAML
+openapi: 3.0.0
+servers:
+  - url: 'http://localhost:8000/api'
+paths:
+  /list:
+    get:
+        parameters:
+            - in: query
+              name: filter
+              style: deepObject
+              allowReserved: true
+              schema:
+                type: object
+                properties:
+                  filters:
+                    oneOf:
+                        -
+                            type: object
+                            required:
+                              - max
+                            properties:
+                              max:
+                                type: number
+                        -
+                            type: object
+                            required:
+                              - min
+                            properties:
+                              min:
+                                type: number
+YAML;
+
+        $validator = (new ValidatorBuilder())->fromYaml($yaml)->getServerRequestValidator();
+
+        $queryString = 'filter[filters][min]=1';
+        $query       = null;
+        parse_str($queryString, $query);
+
+        $psrRequest = (new ServerRequest('get', 'http://localhost:8000/api/list'))
+            ->withHeader('Content-Type', 'application/json')
+            ->withQueryParams($query);
+
+        try {
+            $validator->validate($psrRequest);
+            $this->assertTrue(true);
+        } catch (InvalidQueryArgs $e) {
+            self::fail('Should not throw an exception');
+        }
+    }
+}