Skip to content

Commit

Permalink
Addition to for #31
Browse files Browse the repository at this point in the history
The value detection of "MINIO_USE_HTTPS" was faulty. False values were treated incorrectly.
  • Loading branch information
theriverman committed Nov 6, 2021
1 parent d889d66 commit fff26e6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions django_minio_backend/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ def validate_settings(self):
"""
validate_settings raises a ConfigurationError exception when one of the following conditions is met:
* Neither MINIO_PRIVATE_BUCKETS nor MINIO_PUBLIC_BUCKETS have been declared and configured with at least 1 bucket
* A mandatory parameter (ENDPOINT, ACCESS_KEY or SECRET_KEY) hasn't been declared and configured properly
* A mandatory parameter (ENDPOINT, ACCESS_KEY, SECRET_KEY or USE_HTTP) hasn't been declared and configured properly
"""
# minimum 1 bucket has to be declared
if not (get_setting("MINIO_PRIVATE_BUCKETS") or get_setting("MINIO_PUBLIC_BUCKETS")):
Expand All @@ -432,9 +432,9 @@ def validate_settings(self):
)
# mandatory parameters must be configured
mandatory_parameters = (self.__MINIO_ENDPOINT, self.__MINIO_ACCESS_KEY, self.__MINIO_SECRET_KEY)
if any([bool(x) is False for x in mandatory_parameters]):
if any([bool(x) is False for x in mandatory_parameters]) or (get_setting("MINIO_USE_HTTPS") is None):
raise ConfigurationError(
"A mandatory parameter (ENDPOINT, ACCESS_KEY, or SECRET_KEY) hasn't been configured properly"
"A mandatory parameter (MINIO_ENDPOINT, MINIO_ACCESS_KEY, MINIO_SECRET_KEY or MINIO_USE_HTTPS) hasn't been configured properly"
)


Expand Down

0 comments on commit fff26e6

Please sign in to comment.