Skip to content

Commit

Permalink
Agile points limitation fix
Browse files Browse the repository at this point in the history
  * Updated various agile point struct members from int to float64
  * Added limitation text to README for 32-bit arm CPUs
  • Loading branch information
theriverman committed Feb 28, 2021
1 parent 0cd1808 commit 77dcf19
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Taiga is an Agile, Free and Open Source Project Management Tool.

Should you have any ideas or recommendations, feel free to report it as an issue or open a pull request.

## Known Limitations
* Some model members holding integers (i.e. `backlog_order`) were implemented using `int` instead of `int64` or rather `uint64` in some cases which results in runtime errors on machines with **32-bit arm** CPUs.

# Integration
Download **Taigo**:
```bash
Expand Down
4 changes: 1 addition & 3 deletions milestones.models.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@ import (

// TODO
/*
Find a way to fetch and store custom Taiga headers:
- Taiga-Info-Total-Opened-Milestones
- Taiga-Info-Total-Closed-Milestones
*/

// Milestone represents all fields of a Milestone(Sprint)
Expand All @@ -25,7 +23,7 @@ type Milestone struct {
EstimatedFinish string `json:"estimated_finish"`
EstimatedStart string `json:"estimated_start"`
Closed bool `json:"closed,omitempty"`
ClosedPoints int `json:"closed_points,omitempty"`
ClosedPoints float64 `json:"closed_points,omitempty"`
CreatedDate time.Time `json:"created_date,omitempty"`
Disponibility float64 `json:"disponibility,omitempty"`
ModifiedDate time.Time `json:"modified_date,omitempty"`
Expand Down
8 changes: 4 additions & 4 deletions projects.models.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type ProjectPoints struct {
Name string `json:"name"`
ID int `json:"id"`
ProjectID int `json:"project_id"`
Value *float32 `json:"value"`
Value *float64 `json:"value"`
}

// IsValueNil returns true if ProjectPoints.Value is nil
Expand Down Expand Up @@ -71,7 +71,7 @@ type ProjectDetail struct {
DefaultEpicStatus int `json:"default_epic_status"`
DefaultIssueStatus int `json:"default_issue_status"`
DefaultIssueType int `json:"default_issue_type"`
DefaultPoints int `json:"default_points"`
DefaultPoints float64 `json:"default_points"`
DefaultPriority int `json:"default_priority"`
DefaultSeverity int `json:"default_severity"`
DefaultTaskStatus int `json:"default_task_status"`
Expand Down Expand Up @@ -361,7 +361,7 @@ type ProjectsList []struct {
IAmAdmin bool `json:"i_am_admin"`
DefaultIssueStatus int `json:"default_issue_status"`
CreationTemplate int `json:"creation_template"`
TotalStoryPoints int `json:"total_story_points"`
TotalStoryPoints float64 `json:"total_story_points"`
AnonPermissions []string `json:"anon_permissions"`
TotalFans int `json:"total_fans"`
IsBacklogActivated bool `json:"is_backlog_activated"`
Expand All @@ -386,7 +386,7 @@ type ProjectsList []struct {
TotalActivity int `json:"total_activity"`
IAmMember bool `json:"i_am_member"`
TotalFansLastYear int `json:"total_fans_last_year"`
DefaultPoints int `json:"default_points"`
DefaultPoints float64 `json:"default_points"`
DefaultTaskStatus int `json:"default_task_status"`
}

Expand Down

0 comments on commit 77dcf19

Please sign in to comment.