Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a view function in RoyaltiesRegistry #1284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adjisb
Copy link
Contributor

@adjisb adjisb commented Nov 1, 2023

Add a function that return the royalties without touching the storage. The previous one that has a royalty type cache is named: getRoyaltiesWithTypeCache now

Description

Brief description of the issue or feature implemented in this PR.

Link to Jira Issue or relevant doc

Dev

Any explanation for the devs that will review your implementation/code.

Qa

Any guidance or important information for the team that will be testing your solution.

Note: you can add any additional information you think is important for giving context to your PR.

Checklist and Markdown

  • Remember you could add any type of formatting to enhance your PR.
  • Like this checklist
  • And with this markdown format

Add a function that return the royalties without touching the storage.
The previous one that has a royalty type cache is named: getRoyaltiesWithTypeCache now
@adjisb adjisb requested a review from a team as a code owner November 1, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant