-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/nft collection #1568
Draft
adjisb
wants to merge
44
commits into
master
Choose a base branch
from
feat/nft-collection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat/nft collection #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/nft collection
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
adjisb
force-pushed
the
feat/nft-collection
branch
4 times, most recently
from
August 9, 2024 14:57
658133a
to
201b6e8
Compare
adjisb
force-pushed
the
feat/nft-collection
branch
from
August 22, 2024 18:36
1e9d2d9
to
f8cd396
Compare
adjisb
force-pushed
the
feat/nft-collection
branch
2 times, most recently
from
September 11, 2024 16:45
b44d0d7
to
2259967
Compare
adjisb
force-pushed
the
feat/nft-collection
branch
from
October 16, 2024 13:18
684024e
to
17c49f2
Compare
adjisb
force-pushed
the
feat/nft-collection
branch
2 times, most recently
from
December 9, 2024 15:00
212ca09
to
a268b9b
Compare
Non gas optimized version of the transfer methods
fix the tests because there where using the wrong contract
Initialize is stil too big, we need to rewiew it.
let the contract initialize without a trusted forwarder improve emited events during initialization
Also some small improvementes to the contract
adjisb
force-pushed
the
feat/nft-collection
branch
from
December 16, 2024 16:46
2d2404c
to
4291ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NFT Collection