Update daemon PID before parent exits #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will have the parent process write the daemon PID before it exits. This ensures that immediately after parent exits a valid PID is available from the pid file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an issue that I wish to
waiton the daemon PID so ask for the contents of the pid file immediately after the call to start the daemon. The problem is that there is a delay between the parent process exiting and the daemon writing it's actual PID to the pidfile. During this window the PID file exists but is empty so I can'twaiton the PID unless I have asleepimmediately after starting the daemon. This seemed like an clumsy solution so the proposed change would see the parent (which knows the daemon PID) write it out immediately before exiting.I hope you agree this is a sensible change. If not, perhaps you can think of a different solution.