Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: npm package publish #3

Closed
wants to merge 7 commits into from
Closed

feat: npm package publish #3

wants to merge 7 commits into from

Conversation

n4l5u0r
Copy link
Collaborator

@n4l5u0r n4l5u0r commented Sep 25, 2024

No description provided.

@Z4karia Z4karia self-requested a review September 25, 2024 10:41
Z4karia
Z4karia previously approved these changes Sep 25, 2024
View reviewed changes
@Z4karia Z4karia requested a review from GuilaneDen September 25, 2024 10:41
@n4l5u0r n4l5u0r requested review from a team and removed request for GuilaneDen September 25, 2024 10:48
@n4l5u0r n4l5u0r self-assigned this Sep 25, 2024
@n4l5u0r n4l5u0r requested review from a team and removed request for a team September 25, 2024 10:52
n4l5u0r
n4l5u0r commented Sep 25, 2024
View reviewed changes
Copy link
Collaborator Author

@n4l5u0r n4l5u0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some latest btc mentions to replace

tests/Btc.integration.test.ts.disabled Outdated
@@ -155,9 +155,9 @@ async function transport(): Promise<SpeculosTransport> {
async function impl(
variant: "old" | "new",
transport: Transport
): Promise<Btc | BtcNew> {
): Promise<Acre | BtcNew> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btc

tests/Btc.test.ts.disabled Outdated
@@ -120,7 +120,7 @@ ascii(1NjiCsVBuKDT62LmaUd7WZZZBK2gPAkisb)
`)
);
// This test covers the old bitcoin Nano app 1.6 API, before the breaking changes that occurred in v2.1.0 of the app
const btc = new Btc({ transport, currency: "oldbitcoin" });
const btc = new Acre({ transport, currency: "oldbitcoin" });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc

tests/Btc.test.ts.disabled Outdated
Comment on lines 140 to 141
// This test covers the old bitcoin Nano app 1.6 API, before the breaking changes that occurred in v2.1.0 of the app
const btc = new Btc({ transport, currency: "oldbitcoin" });
const btc = new Acre({ transport, currency: "oldbitcoin" });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc

README.md Outdated
@@ -28,7 +28,7 @@ For a smooth and quick integration:
#### Table of Contents

* [bippath](#bippath)
* [Btc](#btc)
* [Acre](#btc)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc ?

README.md Outdated
import Btc from "@blooo/hw-app-acre:";
const btc = new Btc({ transport, currency: "bitcoin" });
import Acre from "@blooo/hw-app-acre:";
const btc = new Acre({ transport, currency: "bitcoin" });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

README.md Outdated
@@ -341,16 +341,14 @@ Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/G
### BtcNew
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is it BtcNew in Acre contexte?

tests/Btc.test.ts.disabled Outdated
@@ -373,7 +373,7 @@ test("btc sign p2sh seg", async () => {
<= 3045022100932934ee326c19c81b72fb03cec0fb79ff980a8076639f77c7edec35bd59da1e02205e4030e8e0fd2405f6db2fe044c49d3f191adbdc0e05ec7ed4dcc4c6fe7310e5019000
`)
);
const btc = new Btc({ transport });
const btc = new Acre({ transport });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc

tests/Btc.test.ts.disabled Outdated
@@ -324,7 +324,7 @@ test("btc seg multi", async () => {
`)
);
// This test covers the old bitcoin Nano app 1.6 API, before the breaking changes that occurred in v2.1.0 of the app
const btc = new Btc({ transport, currency: "oldbitcoin" });
const btc = new Acree({ transport, currency: "oldbitcoin" });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc

tests/Btc.test.ts.disabled Outdated
@@ -272,7 +272,7 @@ test("btc 4", async () => {
<= 3045022100e32b32b8a6b4228155ba4d1a536d8fed9900606663fbbf4ea420ed8e944f9c18022053c97c74d2f6d8620d060584dc7886f5f3003684bb249508eb7066215172281a9000
`)
);
const btc = new Btc({ transport });
const btc = new Acre({ transport });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc

tests/Btc.test.ts.disabled Outdated
@@ -406,7 +406,7 @@ test("signMessage", async () => {
<= 314402205eac720be544d3959a760d9bfd6a0e7c86d128fd1030038f06d85822608804e20220385d83273c9d03c469596292fb354b07d193034f83c2633a4c1f057838e12a5b9000
`)
);
const btc = new Btc({ transport });
const btc = new Acre({ transport });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc

@n4l5u0r n4l5u0r requested review from GuilaneDen and removed request for a team September 25, 2024 11:49
@n4l5u0r n4l5u0r assigned Z4karia and unassigned n4l5u0r Sep 25, 2024
@n4l5u0r n4l5u0r requested review from a team and removed request for a team September 25, 2024 11:59
@n4l5u0r n4l5u0r closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Z4karia Z4karia Z4karia left review comments

@GuilaneDen GuilaneDen Awaiting requested review from GuilaneDen

Assignees

@Z4karia Z4karia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n4l5u0r @Z4karia