Use union type instead of enum for ExplorerDataType

thesis · Jan 19, 2024 · 1eae36a · 1eae36a
1 parent 6da5a2a
commit 1eae36a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/dapp/src/components/TransactionHistory/Table/Cell/components/BlockExplorer.tsx b/dapp/src/components/TransactionHistory/Table/Cell/components/BlockExplorer.tsx
@@ -1,5 +1,5 @@
 import React from "react"
-import { Chain, ExplorerDataType } from "#/types"
+import { Chain } from "#/types"
 import { BLOCK_EXPLORER } from "#/constants"
 import ViewInBlockExplorer from "#/components/shared/ViewInBlockExplorer"
 import SimpleText from "./SimpleText"
@@ -9,7 +9,7 @@ function BlockExplorer({ txHash, chain }: { txHash?: string; chain: Chain }) {
     return (
       <ViewInBlockExplorer
         id={txHash}
-        type={ExplorerDataType.TRANSACTION}
+        type="transaction"
         chain={chain}
         size="sm"
       />

diff --git a/dapp/src/types/chain.ts b/dapp/src/types/chain.ts
@@ -1,5 +1,3 @@
 export type Chain = "bitcoin" | "ethereum"
 
-export enum ExplorerDataType {
-  TRANSACTION = "transaction",
-}
+export type ExplorerDataType = "transaction"
diff --git a/dapp/src/utils/chain.ts b/dapp/src/utils/chain.ts
@@ -7,7 +7,7 @@ export const createBlockExplorerLink = (
   type: ExplorerDataType,
 ) => {
   switch (type) {
-    case ExplorerDataType.TRANSACTION:
+    case "transaction":
     default: {
       return `${prefix}/tx/${id}`
     }