Resolve too much props passed to component issue

thesis · Aug 12, 2024 · 56950f3 · 56950f3
1 parent 358e904
commit 56950f3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/dapp/src/components/shared/ActivitiesList/ActivitiesList.tsx b/dapp/src/components/shared/ActivitiesList/ActivitiesList.tsx
@@ -31,9 +31,9 @@ function ActivitiesList(props: ListProps) {
   return (
     <MotionList pos="relative" w="full" {...props}>
       <AnimatePresence mode="popLayout">
-        {latestActivities.map((item) => (
+        {latestActivities.map(({ id, amount, status, type, txHash }) => (
           <MotionListItem
-            key={item.id}
+            key={id}
             layout="position"
             variants={listItemVariants}
             initial={false}
@@ -43,8 +43,11 @@ function ActivitiesList(props: ListProps) {
             _last={{ pb: 0 }}
           >
             <ActivitiesListItem
-              {...item}
-              handleDismiss={() => handleItemDismiss(item.id)}
+              amount={amount}
+              status={status}
+              type={type}
+              txHash={txHash}
+              handleDismiss={() => handleItemDismiss(id)}
             />
           </MotionListItem>
         ))}

diff --git a/dapp/src/components/shared/ActivitiesList/ActivitiesListItem.tsx b/dapp/src/components/shared/ActivitiesList/ActivitiesListItem.tsx
@@ -14,7 +14,7 @@ import {
 import { TextMd } from "../Typography"
 
 type ActivitiesListItemProps = Omit<AlertProps, "status"> &
-  ActivityType & {
+  Omit<ActivityType, "id" | "finalizedAt" | "initializedAt"> & {
     handleDismiss?: () => void
   }