Adding two additional custom errors

Added NotMaintainer and NotStbtc to better understand the error if occurs.
thesis · Apr 10, 2024 · 7a2b52b · 7a2b52b
1 parent 89585dc
commit 7a2b52b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/core/contracts/MezoAllocator.sol b/core/contracts/MezoAllocator.sol
@@ -96,13 +96,17 @@ contract MezoAllocator is IDispatcher, Ownable2Step {
     /// @notice Reverts if the caller is not an authorized account.
     error NotAuthorized();
     /// @notice Reverts if the caller is not a maintainer.
+    error NotMaintainer();
+    /// @notice Reverts if the caller is not the stBTC contract.
+    error NotStbtc();
+    /// @notice Reverts if the caller is not a maintainer.
     error MaintainerNotRegistered();
     /// @notice Reverts if the caller is already a maintainer.
     error MaintainerAlreadyRegistered();
 
     modifier onlyMaintainer() {
         if (!isMaintainer[msg.sender]) {
-            revert NotAuthorized();
+            revert NotMaintainer();
         }
         _;
     }
@@ -171,7 +175,7 @@ contract MezoAllocator is IDispatcher, Ownable2Step {
     ///         MezoPortal for a given deposit id.
     /// @param amount Amount of tBTC to withdraw.
     function withdraw(uint256 amount) external {
-        if (msg.sender != address(stbtc)) revert NotAuthorized();
+        if (msg.sender != address(stbtc)) revert NotStbtc();
 
         emit DepositWithdrawn(depositId, amount);
         mezoPortal.withdraw(address(tbtc), depositId, uint96(amount));

diff --git a/core/test/MezoAllocator.test.ts b/core/test/MezoAllocator.test.ts
@@ -65,7 +65,7 @@ describe("MezoAllocator", () => {
       it("should revert", async () => {
         await expect(
           mezoAllocator.connect(thirdParty).allocate(),
-        ).to.be.revertedWithCustomError(mezoAllocator, "NotAuthorized")
+        ).to.be.revertedWithCustomError(mezoAllocator, "NotMaintainer")
       })
     })
 
@@ -153,7 +153,7 @@ describe("MezoAllocator", () => {
       it("should revert", async () => {
         await expect(
           mezoAllocator.connect(thirdParty).withdraw(1n),
-        ).to.be.revertedWithCustomError(mezoAllocator, "NotAuthorized")
+        ).to.be.revertedWithCustomError(mezoAllocator, "NotStbtc")
       })
     })