Implement fees ceiling

thesis · Aug 13, 2024 · 8054c94 · 8054c94
1 parent 7a3ee4a
commit 8054c94
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/dapp/src/components/TransactionModal/ActiveStakingStep/StakeFormModal/StakeDetails.tsx b/dapp/src/components/TransactionModal/ActiveStakingStep/StakeFormModal/StakeDetails.tsx
@@ -6,7 +6,7 @@ import { useTokenAmountField } from "#/components/shared/TokenAmountForm/TokenAm
 import { FeesTooltip } from "#/components/TransactionModal/FeesTooltip"
 import { useMinDepositAmount, useTransactionDetails } from "#/hooks"
 import { CurrencyType } from "#/types"
-import { DESIRED_DECIMALS_FOR_FEE } from "#/constants"
+import { DESIRED_DECIMALS_FOR_FEE, FEE_CEIL_PRECISION } from "#/constants"
 
 function StakeDetails({ currency }: { currency: CurrencyType }) {
   const { value = 0n } = useTokenAmountField()
@@ -36,6 +36,7 @@ function StakeDetails({ currency }: { currency: CurrencyType }) {
           currency,
           amount: total,
           desiredDecimals: DESIRED_DECIMALS_FOR_FEE,
+          ceilPrecision: FEE_CEIL_PRECISION,
         }}
         to={{
           currency: "usd",

diff --git a/dapp/src/components/shared/CurrencyBalance/index.tsx b/dapp/src/components/shared/CurrencyBalance/index.tsx
@@ -17,6 +17,7 @@ export type CurrencyBalanceProps = {
   amount?: AmountType
   shouldBeFormatted?: boolean
   desiredDecimals?: number
+  ceilPrecision?: number
   size?: ResponsiveValue<string>
   variant?: ResponsiveValue<
     | "greater-balance-md"
@@ -34,6 +35,7 @@ export function CurrencyBalance({
   amount,
   shouldBeFormatted = true,
   desiredDecimals: customDesiredDecimals,
+  ceilPrecision,
   size,
   variant,
   balanceFontWeight = "bold",
@@ -58,10 +60,10 @@ export function CurrencyBalance({
   const balance = useMemo(() => {
     const value = amount ?? 0
     if (shouldBeFormatted || typeof value === "bigint")
-      return formatTokenAmount(value, decimals, desiredDecimals)
+      return formatTokenAmount(value, decimals, desiredDecimals, ceilPrecision)
 
     return numberToLocaleString(value, desiredDecimals)
-  }, [amount, decimals, desiredDecimals, shouldBeFormatted])
+  }, [amount, decimals, desiredDecimals, shouldBeFormatted, ceilPrecision])
 
   return (
     <Box as={as} __css={styles.container}>

diff --git a/dapp/src/constants/currency.ts b/dapp/src/constants/currency.ts
@@ -2,6 +2,7 @@ import { Currency, CurrencyType } from "#/types"
 import env from "./env"
 
 export const DESIRED_DECIMALS_FOR_FEE = 5
+export const FEE_CEIL_PRECISION = 4
 
 export const BITCOIN: Currency = {
   name: "Bitcoin",

diff --git a/dapp/src/utils/numbers.ts b/dapp/src/utils/numbers.ts
@@ -52,18 +52,24 @@ export const formatTokenAmount = (
   amount: number | string | bigint,
   decimals = 18,
   desiredDecimals = 2,
+  ceilPrecision = desiredDecimals,
 ) => {
   const fixedPoint = BigInt(amount)
 
   if (fixedPoint === 0n) {
     return `0.${"0".repeat(desiredDecimals)}`
   }
 
-  const formattedAmount = bigIntToUserAmount(
+  let formattedAmount = bigIntToUserAmount(
     fixedPoint,
     decimals,
     desiredDecimals,
   )
+  if (ceilPrecision !== desiredDecimals) {
+    formattedAmount =
+      Math.ceil(formattedAmount * 10 ** ceilPrecision) / 10 ** ceilPrecision
+  }
+
   const minAmountToDisplay = 1 / 10 ** Math.min(desiredDecimals, decimals)
 
   if (minAmountToDisplay > formattedAmount) {