Adding withArgs checks for CustomErrors validations

thesis · Jan 2, 2024 · 9e6c630 · 9e6c630
1 parent c18d23b
commit 9e6c630
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/core/test/Acre.test.ts b/core/test/Acre.test.ts
@@ -823,9 +823,9 @@ describe("Acre", () => {
   describe("updateDispatcher", () => {
     context("when caller is not an owner", () => {
       it("should revert", async () => {
-        await expect(
-          acre.connect(staker1).updateDispatcher(ZeroAddress),
-        ).to.be.revertedWithCustomError(acre, "OwnableUnauthorizedAccount")
+        await expect(acre.connect(staker1).updateDispatcher(ZeroAddress))
+          .to.be.revertedWithCustomError(acre, "OwnableUnauthorizedAccount")
+          .withArgs(staker1.address)
       })
     })
 

diff --git a/core/test/Dispatcher.test.ts b/core/test/Dispatcher.test.ts
@@ -58,10 +58,12 @@ describe("Dispatcher", () => {
       it("should revert when adding a vault", async () => {
         await expect(
           dispatcher.connect(thirdParty).authorizeVault(vaultAddress1),
-        ).to.be.revertedWithCustomError(
-          dispatcher,
-          "OwnableUnauthorizedAccount",
         )
+          .to.be.revertedWithCustomError(
+            dispatcher,
+            "OwnableUnauthorizedAccount",
+          )
+          .withArgs(thirdParty.address)
       })
     })
 
@@ -110,10 +112,12 @@ describe("Dispatcher", () => {
       it("should revert when adding a vault", async () => {
         await expect(
           dispatcher.connect(thirdParty).deauthorizeVault(vaultAddress1),
-        ).to.be.revertedWithCustomError(
-          dispatcher,
-          "OwnableUnauthorizedAccount",
         )
+          .to.be.revertedWithCustomError(
+            dispatcher,
+            "OwnableUnauthorizedAccount",
+          )
+          .withArgs(thirdParty.address)
       })
     })
 
@@ -256,10 +260,12 @@ describe("Dispatcher", () => {
       it("should revert", async () => {
         await expect(
           dispatcher.connect(thirdParty).updateMaintainer(newMaintainer),
-        ).to.be.revertedWithCustomError(
-          dispatcher,
-          "OwnableUnauthorizedAccount",
         )
+          .to.be.revertedWithCustomError(
+            dispatcher,
+            "OwnableUnauthorizedAccount",
+          )
+          .withArgs(thirdParty.address)
       })
     })