Eslint config: fix no-floating-promises rule

thesis · Jan 16, 2024 · d2ead5b · d2ead5b
1 parent 2eabd86
commit d2ead5b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 15 deletions.
diff --git a/dapp/.eslintrc b/dapp/.eslintrc
@@ -17,19 +17,6 @@
     ],
     "react/require-default-props": [0],
   },
-  // FIXME: 
-  // This is temporary solution after changes of the eslint-config version: @thesis-co/eslint-config: "github:thesis/eslint-config#7b9bc8c"
-  // Overrides rules should be fixed file by file.
-  "overrides": [
-    {
-      "files": [
-        "src/hooks/useSignMessage.ts"
-      ],
-      "rules": {
-        "@typescript-eslint/no-floating-promises": "off"
-      }
-    },
-  ],
   "settings": {
     "import/resolver": {
       "alias": {

diff --git a/dapp/src/hooks/useDepositBTCTransaction.ts b/dapp/src/hooks/useDepositBTCTransaction.ts
@@ -6,7 +6,6 @@ export function useDepositBTCTransaction(onSuccess?: OnSuccessCallback) {
   const depositBTC = useCallback(() => {
     if (onSuccess) {
       // FIXME: enable eslint rule when SDK ready
-      // eslint-disable-next-line @typescript-eslint/no-misused-promises
       setTimeout(onSuccess, 1000)
     }
   }, [onSuccess])

diff --git a/dapp/src/types/callback.ts b/dapp/src/types/callback.ts
@@ -1 +1 @@
-export type OnSuccessCallback = () => void | Promise<void>
+export type OnSuccessCallback = () => void
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export type OnSuccessCallback = () => void \| Promise<void>
		export type OnSuccessCallback = () => void