Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pagination components #705

Open
kkosiorowska opened this issue Aug 16, 2024 · 0 comments
Open

Improve Pagination components #705

kkosiorowska opened this issue Aug 16, 2024 · 0 comments
Labels

Comments

@kkosiorowska
Copy link
Contributor

kkosiorowska commented Aug 16, 2024

When we add some new element under the PaginationPage or Pagination tag, the list of activities will overlap it when we switch pages. The PaginationPage component affects other elements.

This component/animation should be improved so that it does not affect other components. Using the component should be very simple and should not require additional style fixes.

Screen.Recording.2024-08-14.at.11.04.29.mov
kpyszkowski added a commit that referenced this issue Aug 21, 2024
Closes #684

This PR adds the estimated duration for new transactions. All
transactions will be displayed in the history table. However,
notifications will only show completed ones and the list of activity
notifications will be shown at the top.

#### What has been done:

- Displayed the estimated duration in the staking and unstaking tiles.
- Implemented the UI changes in the middle column components (pending
transactions, position, transactions history).
- Fixed activity sorting in the history table. -
362c27e
- Added custom styles for a symbol in the `CurrencyBalance` component.
-32fe952
- Added additional dots for the `CurrencyBalance` component. -
d62c97d

During the implementation of the UI changes for the middle column, the
padding was changed. This change also affected the pagination buttons
for the activity table. These components should be separate and should
not affect each other. In addition, it was noted that when we add some
new element under the `PaginationPage` or `Pagination` tag, the list of
activities will overlap it when we switch pages. For this purpose, the
`PaginationFooter` component was created as a temporary solution. We
should resolve this in a separate PR. Created an issue -
#705

### UI


<img width="500" alt="Screenshot 2024-08-14 at 12 13 43"
src="https://github.com/user-attachments/assets/95033693-1580-4ac8-a948-2976973e40cb">

<img width="500" alt="Screenshot 2024-08-14 at 13 51 24"
src="https://github.com/user-attachments/assets/339189b6-6271-4177-bebc-43e84105e2b8">


### Testing

Make sure we display the correct estimated duration:
- Staking
 - [x] < 0.1 BTC               ~1 hour
 - [x] >= 0.1 BTC  < 1 BTC     ~2 hours
 - [x] >= 1 BTC                ~3 hours
- Unstaking
 - [ ] We display 6 hours, regardless of the amount.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant