Show estimated duration for new transactions #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show only the latest completed activities - show notifications top of the card
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is a temporary solution. It should be fixed by updating the animations or Pagination component.
After the latest changes, pending transactions are also displayed in the main activity table. Therefore, the withdrawal activity should also be initialized in `activities` state.
nkuba
reviewed
Aug 19, 2024
kpyszkowski
reviewed
Aug 19, 2024
| pt={6} | ||
| bgGradient="linear(to-b, transparent, gold.200 20%)" | ||
| zIndex={2} | ||
| // TODO: Temporary solution - Animation should be fixed in such a way |
There was a problem hiding this comment.
Could you give an example of the issue or elaborate some more? I don't understand the issue to be honest.
There was a problem hiding this comment.
You can find more details in #705. There is an example video of issue.
There was a problem hiding this comment.
Conceptually this component was supposed to be headless to make composition easier, hence the need to add styles separately is reasonable.
But leaving that aside, the animation bug is there and needs to be addressed sooner or later.
Co-authored-by: Jakub Nowakowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #684
This PR adds the estimated duration for new transactions. All transactions will be displayed in the history table. However, notifications will only show completed ones and the list of activity notifications will be shown at the top.
What has been done:
CurrencyBalancecomponent. -32fe952CurrencyBalancecomponent. - d62c97dDuring the implementation of the UI changes for the middle column, the padding was changed. This change also affected the pagination buttons for the activity table. These components should be separate and should not affect each other. In addition, it was noted that when we add some new element under the
PaginationPageorPaginationtag, the list of activities will overlap it when we switch pages. For this purpose, thePaginationFootercomponent was created as a temporary solution. We should resolve this in a separate PR. Created an issue - #705UI
Testing
Make sure we display the correct estimated duration: