Resuming deposit modal #138
Conversation
ioay
force-pushed
the
resuming-deposit-modal
branch
2 times, most recently
from
dc84755 to
a98ba62
Compare
ioay
force-pushed
the
resuming-deposit-modal
branch
from
a98ba62 to
4b32328
Compare
| import { Pause } from "#/static/icons" | ||
| import { TextMd } from "#/components/shared/Typography" | ||
|
|
||
| export default function ResumeModal({ |
There was a problem hiding this comment.
I think we can only name it as Resume. We are in the modals directory so it seems redundant to me. We had the same approach with MissingAccount or other modals declared here. The same goes for the file name.
| export default function ResumeModal({ | |
| export default function Resume({ |
There was a problem hiding this comment.
We can keep the file name without the suffix modal because we are in the modals directory, but I recommend staying with the current naming convention of components because such a name says more about the component type and will not be confused with the name of a function or other component if it appears and is not modal. I would even recommend such a change in other places as eg: MissingAccountModal.
There was a problem hiding this comment.
Discussion moved to discord
There was a problem hiding this comment.
The suffix may be useful when we import this modal and use it elsewhere, it adds clarity.
On the other hand we've already got bunch of components that don't have the suffixes:
ActionForm, Overview, etc.
Also let's take Details list, should it be renamed to DetailsList?
Should Pause icon become a PauseIcon?
There was a problem hiding this comment.
It feels like a deeper discussion to establish the common patterns, that we shouldn't block this PR with, unless we agree on the pattern and decide to refactor it across the board in a follow-up.
There was a problem hiding this comment.
(I left some much more detailed thoughts in the Discord thread, but quick answers on the above two examples: Pause should be PauseIcon, and Details should have a more descriptive name than Details or DetailsList! Details of what?)
| import { Pause } from "#/static/icons" | ||
| import { TextMd } from "#/components/shared/Typography" | ||
|
|
||
| export default function ResumeModal({ |
There was a problem hiding this comment.
Discussion moved to discord
Closes: #110
When a user leaves the staking flow, the user is asked for confirmation.
Figma: https://www.figma.com/file/OUdSfHsmgV8EJpWxAzXjl5/Design-Tasks?type=design&node-id=3799-15142&mode=design&t=1vG9C2eujbt5Q5tk-4