-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite config: import aliases, eslint config #142
Conversation
In this PR in addition to defining aliases, we're restructuring the code by moving some content to the What do you think about splitting aliases and asset changes into two separate commits (ideally two separate PRs)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it is simpler to use the @
alias instead of @~
. I understand that we want to distinguish local files from external packages. But I wonder if it is really necessary. 🤔
I'm open to discussing the naming convention, but just
@r-czajkowski what are your preferences? |
I was changing aliases everywhere, so I moved this one too. It's just for fonts used in one file. |
What about |
What about |
Agreed, as I mentioned previously - just |
aa8529e
to
6c29635
Compare
6c29635
to
2cdb450
Compare
Closes: #140
Added
@~
prefix to local aliases. Thanks to this, we distinguish local files from external packages.