Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding foundry config #15

Closed
wants to merge 8 commits into from
Closed

Adding foundry config #15

wants to merge 8 commits into from

Conversation

dimpar
Copy link
Member

@dimpar dimpar commented Nov 9, 2023

This PR adds Foundry to make this Hardhat project a hybrid project. Added the following submodules for development:

  • erc4626
  • solmate
  • forge-std
  • ds-test

Github workflow was also adjusted to reflect the addition of the Foundry configs.

Make sure you have forge installed. Run forge --version. Here's a link to install forge: https://getfoundry.sh/

Basic forge commands:
forge build, forge install, forge test

Acre project can take advantage of foundry framework to write tests in
Solidity. Acre now will use a hybrid approach by having tests written in
Solidity and deployment scripts written in TS using HH deployment
plugin.
@dimpar dimpar changed the title Testing acre flow Adding foundry config Nov 21, 2023
@dimpar dimpar requested review from nkuba and r-czajkowski November 21, 2023 14:53
@dimpar dimpar marked this pull request as ready for review November 21, 2023 14:54
@dimpar dimpar self-assigned this Nov 21, 2023
@dimpar
Copy link
Member Author

dimpar commented Nov 22, 2023

The decision was made to not integrate Foundry with Hardhat. ERC4626 lib contracts were copied and pasted here: #40

@dimpar dimpar closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant