Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting function for transaction history table #190

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Add sorting function for transaction history table #190

merged 8 commits into from
Jan 30, 2024

Conversation

kkosiorowska
Copy link
Contributor

@kkosiorowska kkosiorowska commented Jan 22, 2024 •
edited
Loading

⚠️ Please don't merge. The merge will be available after #182

Ref #38

This PR adds functions for sorting the results in the transaction table. To simplify testing, a special function createTransactionInfo was created. It allows us to easily create multiple transactions and customize them. This PR also improves:

  • Text correction for pagination
  • Changed the number of transactions on a single page (default 10)

UI

Screen.Recording.2024-01-23.at.09.28.42.mov

@kkosiorowska kkosiorowska self-assigned this Jan 22, 2024
@kkosiorowska kkosiorowska marked this pull request as ready for review January 23, 2024 08:32
@kkosiorowska kkosiorowska mentioned this pull request Jan 23, 2024
Merged
@kkosiorowska kkosiorowska requested a review from ioay January 23, 2024 08:50
@kkosiorowska kkosiorowska requested a review from ioay January 25, 2024 14:37
ioay
ioay previously approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ioay ioay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Base automatically changed from custom-cells to main January 30, 2024 08:53
@kkosiorowska kkosiorowska dismissed ioay’s stale review January 30, 2024 08:53

The base branch was changed.

@kkosiorowska kkosiorowska merged commit 64a145b into main Jan 30, 2024
11 checks passed
@kkosiorowska kkosiorowska deleted the sorting-table branch January 30, 2024 09:05
@kkosiorowska kkosiorowska mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioay ioay ioay approved these changes

Assignees

@kkosiorowska kkosiorowska

Labels
🎨 dApp dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkosiorowska @ioay