Sentry SDK initialization #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioay
force-pushed
the
sentry-integration
branch
2 times, most recently
from
e68f4ca to
1818c06
Compare
ioay
force-pushed
the
sentry-integration
branch
from
1818c06 to
55b1147
Compare
There was a problem hiding this comment.
I've left a few comments. I have no experience with sentry. Not sure about the criteria for acceptance and testing. So it would be good to expand the description or add some acceptance criteria/steps to check.
I think that here @nkuba or @r-czajkowski should also take a look at it.
nkuba
reviewed
Feb 6, 2024
nkuba
reviewed
Feb 6, 2024
nkuba
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #126
Initial integration of sentrySDK for https://acre-e5.sentry.io/projects/test-dapp-ledger/?project=4506637357416448