Support for xERC4626 #213
Closed
Support for xERC4626 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xERC4626 adds support for rewards (yield) distribution gradually over the rewards cycle length.
Upcomming `allocator` contract will hold rewards/yield, not stBTC. This PR fixes and changes current tests to reflect that. Additionally, xECR4626 overrides totalAsset() function which uses storedTotalAsset params and replaces totalAssets param. This is why a simple mint to stBTC contract won't work to simulate earned yield.
It was decided to remove fees from stBTC contract. Fees will be collected upstream in TBTCDepositor contract or other contract that will trigger deposit flow inside of stBTC contract.
Adjusting tests after fee concept is scratched from the tests scenarios.
For now we can initialize the rewards cycle lenth during the deployment process. We should revisit if 7 days is a good number for rewards cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing fee collection in
stBTC. Bridge and referral fees are collected inTBTCDepositorcontract. If additional fees will need to be collected by Acre, then there should be another contract upstream that will trigger a depositor flow with fee collection for treasury.xERC4626adds support for rewards (yield) distribution gradually over the rewards cycle length period.