Sentry: send initiaited deposit receipt #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkuba let me know if this data sent to the Sentry is enough. |
This was referenced Feb 23, 2024
nkuba
previously requested changes
Feb 23, 2024
…rop & ethAddress as tag
kkosiorowska
dismissed
nkuba’s stale review
The comments have been implemented.
kkosiorowska
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Overall it looks fine and let's not block it. 🚢 I'm not quite sure where and when we want to trigger the sending of deposit information to sentry. But if necessary we will update it in #257 where we will already have full flow.
nkuba
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #202
Submit initiated deposit receipt to sentry:
