Acre subgraph #280
Merged
Acre subgraph #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added subgraph initialization for AcreBitcoinDepositor on Sepolia Testnet. This is the initial configuration generated from the command: `graph init --studio <SUBGRAPH_SLUG>` .
Add docker-compose file to run the graph node locally and update the readme file- describe how to deploy the subgraph locally.
kkosiorowska
force-pushed
the
acre-subgraph
branch
from
273aabd to
b5f26bb
Compare
|
Let's rename the main directory from |
In order to index a network, Graph Node needs access to a network client via an EVM-compatible JSON-RPC API. Let's use RPC from alchemy to do this so that everyone can use their API key. Updated extra parameters to avoid the error of too many requests.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying with
|
| Latest commit: |
eaf44d7
|
| Status: | 🚫 Build failed. |
✅ Deploy Preview for acre-solidity-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dependency to @keep-network/tbtc-v2 was wrongly resolved (merge commit). It should be version: 1.6.0-dev.24(@keep-network/[email protected])
subgraph/package.json
Outdated
Comment on lines
12
to
13
| "lint:eslint": "eslint .", | ||
| "lint:eslint:fix": "eslint . --fix", |
There was a problem hiding this comment.
To keep consistency with other modules in monorepo.
Suggested change
| "lint:eslint": "eslint .", | |
| "lint:eslint:fix": "eslint . --fix", | |
| "lint:js": "eslint .", | |
| "lint:js:fix": "eslint . --fix", |
subgraph/package.json
Outdated
Comment on lines
16
to
17
| "format": "pnpm lint:eslint && pnpm lint:config", | ||
| "format:fix": "pnpm lint:eslint:fix && pnpm lint:config:fix" |
There was a problem hiding this comment.
Suggested change
| "format": "pnpm lint:eslint && pnpm lint:config", | |
| "format:fix": "pnpm lint:eslint:fix && pnpm lint:config:fix" | |
| "format": "npm lint:js && npm lint:config", | |
| "format:fix": "npm lint:js:fix && npm lint:config:fix" |
Not sure if we should call pnpm or npm but to keep consistency with other modules maybe let's use npm
subgraph/package.json
Outdated
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "name": "acre-subgraph", | |||
There was a problem hiding this comment.
Suggested change
| "name": "acre-subgraph", | |
| "name": "@acre-btc/subgraph", |
subgraph/package.json
Outdated
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "name": "acre-subgraph", | |||
| "license": "UNLICENSED", | |||
There was a problem hiding this comment.
Suggested change
| "license": "UNLICENSED", | |
| "license": "GPL-3.0-only", |
cc @nkuba
subgraph/package.json
Outdated
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "name": "acre-subgraph", | |||
There was a problem hiding this comment.
Maybe let's add "version": "0.0.1" as well.
kkosiorowska
force-pushed
the
acre-subgraph
branch
from
970b216 to
0b45658
Compare
This is an initial implementation of the CI process to check the formatting and building in `subgraph` workspace.
kkosiorowska
force-pushed
the
acre-subgraph
branch
from
0b45658 to
c624dac
Compare
There was an error during run tests about missing `assemblyscript` package. This problem occurs with pnpm. Matchstick does not play well with pnpm because of how pnpm handles dependencies. To avoid this problem, let's install this package separately. More info: LimeChain/matchstick#324 (comment)
r-czajkowski
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
LGTM! 🚀 @nkuba could you please take a final look at GH workflow?
nkuba
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263
This PR adds a basic subgraph configuration for the AcreBitcoinDepositor contract. The code was generated automatically by using graph init command. The project also includes eslint and prettier configurations. Docker was used to run the subgraph locally. Currently,
AcreBitcoinDepositoris deployed on the Sepolia Testnet network but it will eventually be on the Ethereum Mainnet.During the work there were a lot of problems over setting up the RPC correctly. Using the RPC from Alchemy there was a problem with the error 429 too many requests. Therefore, for this reason, it was decided to set some extra parameters to reduce requests. However, if you have any suggestions on which RPC we should use or see another solution let me know. Currently, this solution seems the simplest to unblock the next work on data fetching with subgraph.