Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activities bar - added carousel #287
Activities bar - added carousel #287
Changes from 12 commits
389b9e2
c7e0dfc
401f253
f1218a7
7344c8b
19d3693
e93e0ae
ba6d8ee
c78989f
1dd7153
1c5585a
61c0943
cea8744
ae675fd
ebb5f11
40e709a
e870660
eae0720
3b5aea0
a6ba5d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that this is not a problem related to Chakra but to the fact that we have not imported styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if importing additional styles and then overriding the imported styles is needed. To add this kind of style with a lot of we have to install the additional package:
slick-carousel
or import them fromcdn
, another option is to add all these styles into the global styles file which leads to the same thing, only with more styles to remove/overwrite.We just need to add
display: flex
to theslick-track
class (this class is generated under the hood of react-slick, so we can't style it directly in the Carousel component). I'd leave it as it is if you don't mind.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following this approach, let's add a right description of why we do this. Let's document this decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not do it in global styles but in the code related to this carousel. But we can leave it that way now and move it in the future if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably won't change it also for other carousel components if appears. I added a comment to this style when was created:
This file was deleted.
This file was deleted.