Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activities bar - added carousel #287
Activities bar - added carousel #287
Changes from 2 commits
389b9e2
c7e0dfc
401f253
f1218a7
7344c8b
19d3693
e93e0ae
ba6d8ee
c78989f
1dd7153
1c5585a
61c0943
cea8744
ae675fd
ebb5f11
40e709a
e870660
eae0720
3b5aea0
a6ba5d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not do it in global styles but in the code related to this carousel. But we can leave it that way now and move it in the future if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably won't change it also for other carousel components if appears. I added a comment to this style when was created:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should use special compnent for that case from chakra -
LinkOverlay
, because:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced about this solution, since we end up using it anyway prop as={ReactRouterLink} which generates
<a>
element (no matter if we use LinkOverlay/LinkBox). I'm wondering how we can get around this to meet the semantic assumptions 🤔UPDATE:
Added click handler instead of using ChakraLink.: ba6d8ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move to shared components:
I would keep all the utils and component inside
index.ts
file. And then theActivityCarousel
should define responsive breakpoints because we calculate them based on the activity card.`src/components/shared/Carousel/index.tsx
src/components/shared/ActivityCarousel/index.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this carousel should be a shared component, as you noticed: #287 (comment)
it's something specific for OverviewPage only (unique styles, arrow positions, breakpoints, slidesToShow, bgGradient on the right side). What do you think about moving it for now to the OverviewPage directory? If a new carousel appears in the design, we will consider modifying this component depending on what can be shared.
Update:
Slider
with some general props was moved to shared components. Other props and arrows were left in anactivityCarousel
that is more closely related to it.