Read the min amount of BTC deposit from the SDK #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkosiorowska
force-pushed
the
min-amount-btc
branch
from
aee0331 to
836a300
Compare
Add `fromSatoshi` fn that converts an amount from `1e8` to `1e18` token precision. Also here we remove optional `fromPrecision` param in `toSatoshi` fn - we assume we always convert from `1e18` to `1e8` and in `fromSatoshi` we always convert from `1e8` to `1e18`.
The minimum amount of BTC deposit should be taken from `BitcoinDepositor` contract. The amount is in tBTC token precision before export this value in SDK has to be converted to satoshi precision.
Since the minimum staking amount is in bigint, we should standardize it not mix types in the form. This approach also gets rid of the double conversion of tokenBalance to bigint in the `TokenBalanceInput` component and validation method.
The BigInt constructor also accepts the value bigint. There is no need to check whether the number is of type bigint to avoid the constructor.
kkosiorowska
force-pushed
the
min-amount-btc
branch
from
e75be7e to
7e0c787
Compare
kkosiorowska
commented
Apr 10, 2024
There was a problem hiding this comment.
This logic comes from #281. To avoid waiting for this PR, I copied this solution.
ioay
reviewed
Apr 11, 2024
dapp/src/components/TransactionModal/ActiveStakingStep/StakeFormModal/index.tsx
Show resolved
Hide resolved
dapp/src/components/TransactionModal/ActiveUnstakingStep/UnstakeFormModal/index.tsx
Outdated
Show resolved
Hide resolved
We decided not to call the operation stake in the dapp, so for consistency, we align the naming here.
ioay
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
LGTM 🚀 Resolve file conflicts, please.
@r-czajkowski could you take a look at the SDK part?
r-czajkowski
previously approved these changes
Apr 12, 2024
r-czajkowski
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234
Closes #336
This PR reads the minimum amount of BTC deposit from the SDK and saves it in the redux store.
What has been done:
useFetchSdkDatato load all needed data from the SDKbigintfortokenBalnce.CurrencyBalanceto pass the amount inbigintOne note: the contracts have not been deployed yet. Therefore, an error will appear in the console
TypeError: this.instance.minDepositAmount is not a functionHowever, When the contracts are re-deployed I will update the code and the error will disappear.