Handling an error that occurs after a deposit action #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event of an error occurring after the deposit transaction but before displaying the Success screen to the user, there is a low possibility of system issues. To address this, we will show an error screen prompting the user to retry. If the error is episodal, the system will recover, and upon pressing the "Retry" button, the user will see the Success screen, continuing the flow as usual. We intentionally omit a close button, guiding the user to proceed within the flow and preventing abandonment.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
If the user chooses not to retry, a message will inform them that we will automatically retry after a designated time ("x" duration).
kkosiorowska
force-pushed
the
error-after-deposit-action
branch
from
f01bb0e to
17be267
Compare
- functions should be outside the component - functions should not be exported
kkosiorowska
force-pushed
the
error-after-deposit-action
branch
from
d56e30f to
c7b6db9
Compare
kkosiorowska
commented
Apr 2, 2024
kkosiorowska
commented
Apr 3, 2024
Comment on lines
+34
to
+36
| setIsLoading(true) | ||
| await handleStake() | ||
| setIsLoading(false) |
There was a problem hiding this comment.
The useLoading hook will be created in the #327
ioay
reviewed
Apr 6, 2024
dapp/src/components/TransactionModal/ActiveStakingStep/StakingErrorModal/RetryModal.tsx
Outdated
Show resolved
Hide resolved
dapp/src/components/TransactionModal/ActiveStakingStep/StakingErrorModal/ServerErrorModal.tsx
Outdated
Show resolved
Hide resolved
dapp/src/components/TransactionModal/ActiveStakingStep/StakingErrorModal/index.tsx
Outdated
Show resolved
Hide resolved
ioay
reviewed
Apr 6, 2024
kkosiorowska
force-pushed
the
error-after-deposit-action
branch
from
d2035b0 to
5f37071
Compare
The modal content components have been moved to a separate folder. This will simplify the logic of the export
After separating the `content` directory for modals, there was a problem with cycle dependencies. Therefore, all files were moved to a higher directory. This solves the problem with dependencies. In addition, it simplifies the directory structure. However, if we find a new approach in the near future we can easily update it.
ioay
reviewed
Apr 9, 2024
dapp/src/components/TransactionModal/ActiveStakingStep/StakingErrorModal/RetryModal.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for potential errors occurring after the deposit transaction. To handle this, we show an error screen prompting the user to retry. If the error is episodal, upon pressing the "Retry" button, the user will see the Success screen, continuing the flow as usual. We intentionally omit a close button, guiding the user to proceed within the flow and preventing abandonment. If the user chooses not to retry, a message will inform them that we will automatically retry after a designated time - 1 minute. However, if the repeated attempt results in an error, let's show the user the information to look for help on Discord. However, the user should be able to try again from this level.
UI
Test flow recordings
Screen.Recording.2024-04-02.at.16.36.02.mov
Testing
Let's use a patch file to test. Use the following file: test.patch