Fix a prettier config
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the `website/.prettierrc.js` config file defined, so let's remove the redundant config line from the `package.json` file.
The prettier is config in the `dapp/.prettierrc.js` file. This configuration depends on the type value in your `package.json`. Adding "type": "module" in package.json makes all `.js` files ES modules, and then they can only be imported in other ES modules. Prettier is not able to import `.prettierrc.js` because it is now an ES module.
r-czajkowski
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
package.json- The prettier is config in thedapp/.prettierrc.jsfile. This configuration depends on the type value in yourpackage.json. Adding "type": "module" inpackage.jsonmakes all.jsfiles ES modules, and then they can only be imported in other ES modules. Prettier is not able to import.prettierrc.jsbecause it is now an ES module. So let's remove that property.