Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Bitcoin Depositor contract #334

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Rename Bitcoin Depositor contract #334

merged 5 commits into from
Apr 9, 2024

Conversation

nkuba
Copy link
Member

@nkuba nkuba commented Apr 3, 2024

We renamed the depositor contract from AcreBitcoinDepositor to BitcoinDepositor, as there is no point in prefixing the contract with Acre.

We used to do that for ethereum typed messages clear signing, but we no longer need ethereum messages signing with Bitcoin-only experience.

We renamed the depositor contract from AcreBitcoinDepositor to
BitcoinDepositor, as there is no point in prefixing the contract with
Acre.

We used to do that for ethereum typed messages clear signing, but we no
longer need ethereum messages signing with Bitcoin-only experience.
@nkuba nkuba requested a review from dimpar April 3, 2024 18:53
@nkuba nkuba self-assigned this Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for acre-dapp-testnet canceled.

Name Link
🔨 Latest commit cc0f316
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/660feb94869d990008046fc9

@nkuba nkuba added the 🔗 Solidity Solidity contracts label Apr 4, 2024
@dimpar
Copy link
Member

dimpar commented Apr 8, 2024

There are a couple of references of AcreBitcoinDepositor under /subgraph. The rest looks fine.

@nkuba
Copy link
Member Author

nkuba commented Apr 9, 2024

There are a couple of references of AcreBitcoinDepositor under /subgraph. The rest looks fine.

We will update subgraph after we deploy contracts to Sepolia.

@nkuba nkuba added this to the MVP milestone Apr 9, 2024
@dimpar dimpar merged commit 3b3c052 into main Apr 9, 2024
24 checks passed
@dimpar dimpar deleted the bitcoin-depositor-rename branch April 9, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔗 Solidity Solidity contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants