Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing page's card components #369
Landing page's card components #369
Changes from 14 commits
32b5b79
8df74db
99c7abd
9358883
f1644e2
2bc02c4
55cfc58
25a0d69
36bb9e6
3c77258
2f02355
c6249b5
36af881
127b14e
f1a4860
9fc1beb
eb6b37e
81afaea
d08fc7a
07eda72
8487f97
d99f126
b46a423
7340e46
8942ba1
f2f52cd
1043664
6a4e709
49bf329
c1493b3
93c22b6
630db96
1b8eab9
ffadd29
49390ae
20659d0
b978176
d68cb55
1184455
8ca3a0d
b16913a
23e903b
8cd2590
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this name is right. What I mean is that the name
CardButton
is very generic. I have a feeling that it might be a bit confusing and someone might import it by mistake. It seems to me that we should change the name and be more descriptive here. However, I don't have an idea for a name. 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it's a button that looks like a card
Pretty much descriptive for me 😆
Ain't got any other idea tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. This button uses the
card
variant. The only thing this component does is add some additional styles. The nameCardButton
used here makes it look like a shared component. That's why I'm thinking about changing the name or maybe moving it to shared components. At the moment we don't have a style guide so it's difficult to make decisions. So we can leave it as is and then update it later. Just flagging the issue.