-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Landing Page #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented `Layout` component to account `Header` into router's scope for `NavLink` component support used in `Navigation` component
Now content slides in and out in y-axis as the route changes. Also refactored router creation strategy to use components instead of factory function.
With proposed approach it's redundant to wrap each page with `Layout` component - it's handled by the wrapper route.
Adjusted section's background, added additional theme spacing values, adjusted Tag component theme, fixed potential memory leak in background dynamic noise seed.
Updated to follow project's convention
Image assets will be replaced with SVGs
Added new route, updated route paths
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
`ValueCard` to `HighlightedValueCard`
`IconCard` to `BenefitCard`
Used `children` prop instead, added style currency balance child component, update names for consistency
Ref: #355 ## Goal: To implement Landing page's card components ## Features: - `IconCard` component - `ValueCard` component - `ContentCard` component ![localhost_5173_ (1)](https://github.com/thesis/acre/assets/11503879/447ba992-ab34-4f66-a5ee-fecc84780d35)
kkosiorowska
reviewed
May 9, 2024
Merged
kkosiorowska
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #363
Goal:
To implement Landing Page
This PR aggregates all component PRs to finally complete the implementation of landing page
Component PRs:
The list of PRs is given in the issue's description. Each component PR merges to this PR.
Header
component adjustements #357HeroSection
component #364SeasonCountdownSection
component #368Designs: