Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total assets tests #374

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Total assets tests #374

merged 4 commits into from
Apr 24, 2024

Conversation

dimpar
Copy link
Member

@dimpar dimpar commented Apr 22, 2024

Depends on #350

Covering totalAssets() with tests.

Copy link

netlify bot commented Apr 22, 2024

‼️ Deploy request for acre-dapp-testnet rejected.

Learn more in the Netlify docs

Name Link
🔨 Latest commit 565b662

@dimpar dimpar self-assigned this Apr 22, 2024
@dimpar dimpar requested a review from nkuba April 22, 2024 09:54
@nkuba nkuba changed the base branch from main to mo-tests April 23, 2024 11:39
Base automatically changed from mo-tests to main April 23, 2024 11:41
solidity/test/stBTC.test.ts Show resolved Hide resolved
solidity/test/stBTC.test.ts Outdated Show resolved Hide resolved
solidity/test/stBTC.test.ts Outdated Show resolved Hide resolved
solidity/test/stBTC.test.ts Outdated Show resolved Hide resolved
solidity/test/stBTC.test.ts Outdated Show resolved Hide resolved
dimpar added 2 commits April 23, 2024 15:51
- Made executions of tests as separate instances not depending on one
  another
- Calculated the expected value instead of fetching from the contract
- Replaced assignment with 0n to assigning a type of bigint
@dimpar dimpar marked this pull request as ready for review April 23, 2024 13:59
@nkuba nkuba merged commit 7f6adcc into main Apr 24, 2024
20 checks passed
@nkuba nkuba deleted the total-assets-tests branch April 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants