Remove Ethereum account from wallet context #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-czajkowski
force-pushed
the
remove-eth-account
branch
from
f96e32a to
c3b9568
Compare
nkuba
reviewed
May 13, 2024
r-czajkowski
force-pushed
the
remove-eth-account
branch
from
c3b9568 to
7bff98e
Compare
We do not need to connect Ethereum account with the dapp since we want to operate only on the Bitcoin wallet. The Acre SDK will generate the Ethereum address based on the Bitcoin address under the hood and the user's identifier should always be bitcoin address and the SDK will take a care of converting it to Ethereum address under the hood. Still, some features in the Acre SDK expect the Ethereum address eg. to get the estimated bitcoin balance. Hence as a temporary solution we set the ethereum account to zero address to not break the dapp. In the future we want to completely get rid of the ethereum account from the dapp wallet context and we will only pass the bitcoin address to the Acre SDK.
Create the Bitcoin Provider based on the selected bitcoin account id providede by the Ledger Live Wallet API.
Use `initializeMainnet` or `initializeTestnet` fn to init the Acre SDK.
Now the Acre SDK requires the bitcoin provider not ethereum singer.
r-czajkowski
force-pushed
the
remove-eth-account
branch
from
7bff98e to
3cdb91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #371
This PR removes the Ethereum account from the dapp context to implement Bitcoin native experience. Since the signing Bitcoin messages doesn't work in the Ledger Live Wallet API we temporarily removed this step from the deposit flow.