Issue G: Returning zero when the protocol is paused #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stay compliant with the ERC4626 standard we need to return 0 in max* related functions when the protocol is paused.
✅ Deploy Preview for acre-dapp-testnet canceled.
|
dimpar
changed the title
The following functions: deposit, withdraw, redeem, mint already check if the contract is paused or not. This is validated in max* related functions downstream, e.g. maxDeposit(). If the protocol is paused, these max* functions will return zero and stop the flow by reverting a transaction. One of the revert errors might be e.g. ERC4626ExceededMaxDeposit. This way we simplify the flow a little bit and save some gas.
nkuba
approved these changes
May 3, 2024
nkuba
added a commit
that referenced
this pull request
May 9, 2024
Depends on #389 Subtracted fees from `maxWithdraw()` function to align with the rest of the protocol that touch redeem or withdrawal functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stay compliant with the ERC4626 standard we need to return 0 in
max*related functions when the protocol is paused.