Token Staking #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new hh toolbox - Added deployemnt plugin - Added helper scripts - Added linters - Added placeholder dirs for contracts and tests
There are a lot of minor changes to include each in seperate commits. This is a part of the overall project structure. Changes include: - established pattern for the deployment scripts and testing files - cleanup in the package.json and hardhat.config.js - cleanup in prettier, eslint, slither and mocha config files - cleanup in gitignore
Closed
dimpar
reviewed
Oct 27, 2023
There was a problem hiding this comment.
This is more of a high level functionality that I think we need to decide upon:
- Do we allow a BTC staker to increase its stake?
- Do we allow a BTC staker to decrease its stake?
- Set min staking amount. Might be pulled to a different "parameters" contract.
- Set max staking amount. Might be pulled to a different "parameters" contract.
- We might consider adding a
address StakingRouter+authorizeStakingRouter(address) by multisigand wrap it with a modifier which verifies if a caller that request for funds to a Strategy is a indeed a StakingRouter. unauthorizeStakingRouter()- A function that disables/pausing moving funds from this staking contract to a anywhere else.
- Unstake (covered in a different PR).
| } | ||
|
|
||
| function _stake(address account, uint256 amount) private { | ||
| require(amount > 0, "Amount is less than minimum"); |
There was a problem hiding this comment.
We should probably set min and max amounts vars and use it here.
| _stake(msg.sender, amount); | ||
| } | ||
|
|
||
| function _stake(address account, uint256 amount) private { |
r-czajkowski
force-pushed
the
staking
branch
3 times, most recently
from
037bd19 to
ae6c079
Compare
A token staking contract for a specified standard ERC20 token. A holder of the specified token can stake its tokens to this contract and recover the stake after undelegation period is over.
Use ERC20 contracts and libraries to interact with staking token in staking contract.
Add function that stakes owner's tokens in the staking contract - tracks user's staked funds and emit `Staked` event. The minimum amount is required.
Add support for `approveAndCall`/`receiveApproval` pattern. The tBTC token contract that will be a staking token supports this pattern. To be able to stake in one transaction (instead of 2: approve + stake) we must implement the `RecieveApproval` interface. The token staking contract receives approval to spend tokens and create a stake for a given account.
Add min and max staking amount. Currently, functions that return these values have hardcoded values, but in the future we want to pull this param from "parameters" contract that stores governable params.
`account` -> `staker`
We should mint staking token eg. `stBTC` that represents staked token staked with Litmus. It will probably be a rebaseable ERC-20 token.
|
Continued in #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1
Ref: #2
This PR creates the Token Staking contract - a contract for a specified standard ERC20 token. A holder of the specified token can stake its tokens to this contract and recover the stake after undelegation period is over. This contract also supports
approveAndCall/receiveApprovalpattern so users can stake in one transaction (instead of 2:Token.approve+TokenStaking.stake). The initial implementation of staking tracks the staked balance and transfers the staked amount to the staking contract.