Simplify the logic for TransactionModal
#408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modal is a global component and should be rendered on the top of the components tree. It shouldn't be rendered from the `PositionDetails` level.
…te-transaction-modal
kkosiorowska
force-pushed
the
update-transaction-modal
branch
from
8a66e7e to
b9dd2d8
Compare
kkosiorowska
changed the title
kkosiorowska
changed the title
TransactionModal
r-czajkowski
previously approved these changes
May 14, 2024
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
r-czajkowski
approved these changes
May 15, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #394
This PR simplifies the logic of opening modal windows and does a refactor for the
TransacionModalcomponent. The component of the modal type should be global and should not be rendered inside nested components. The new logic allows to define a modal component only once. This will make it easier to call up the deposit flow from the dashboard and landing page. PreviouslyTransacionModalused contexts by what caused a mess in the component. To manage the state of action flow logic, a special slice was created in the redux store.